Skip to content

Revert "eth: dial nodes from discv5 (#30302)"#1489

Merged
manav2401 merged 1 commit intodevelopfrom
jerry/test_p2p
Mar 20, 2025
Merged

Revert "eth: dial nodes from discv5 (#30302)"#1489
manav2401 merged 1 commit intodevelopfrom
jerry/test_p2p

Conversation

@cffls
Copy link
Contributor

@cffls cffls commented Mar 18, 2025

Description

ethereum/go-ethereum#30302 broke PoS DNS discovery. Reverting it fixes the problem.

Tested on a sentry node which wasn't able to get new peers. After reverting the commit, it was able to quickly connected to 50+ peers.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai/amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@cffls cffls requested review from lucca30 and manav2401 March 18, 2025 21:55
@manav2401 manav2401 merged commit 0e7ce27 into develop Mar 20, 2025
10 checks passed
@manav2401 manav2401 deleted the jerry/test_p2p branch March 20, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants